feat(ledger): Added ToPlutusData() function to gov proposal related types #1118
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jenita <[email protected]>
Signed-off-by: Jenita <[email protected]>
agaffney
requested changes
Jul 29, 2025
ledger/common/gov.go
Outdated
| if rat := a.Unknown; rat != (cbor.Rat{}) { | ||
| val := reflect.ValueOf(rat) | ||
| numField := val.FieldByName("num") | ||
| denField := val.FieldByName("den") |
There was a problem hiding this comment.
The big.Rat type (and cbor.Rat which embeds it) have a .Num() and .Denom() function for extracting these values
ledger/common/gov.go
Outdated
| ActionId *GovActionId | ||
| Credentials []Credential | ||
| CredEpochs map[*Credential]uint | ||
| Unknown cbor.Rat |
There was a problem hiding this comment.
While you're here, rename this field to Quorum, since we can now see what it's supposed to be from looking at the Aiken code.
There was a problem hiding this comment.
addressed the comments, could you please review
Signed-off-by: Jenita <[email protected]>
agaffney
approved these changes
Jul 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1106